fix(spa-title): single-project ignored config title. Also added additional tests#2957
Merged
kieronlanning merged 2 commits intoMay 16, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: 748a5b6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 22 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes SPA document title resolution in single-project mode so the overview page uses the project’s configured title (from likec4.config.json) instead of always using the CLI/app pageTitle, aligning behavior with per-view pages and improving user-facing branding consistency.
Changes:
- Update single-project overview route to prefer
project.titleoverpageTitlewhen settingdocument.title. - Add unit tests covering
likec4:app-configvirtual modulepageTitleembedding/encoding and documenting title resolution rules across SPA routes. - Add a changeset to publish the fix as a patch.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
packages/vite-plugin/src/virtuals/app-config.spec.ts |
Adds tests validating default/custom/escaped pageTitle output in the virtual module. |
packages/likec4-spa/src/routes/_single/single-index.tsx |
Fixes single-project overview page title to use project.title ?? pageTitle. |
packages/likec4-spa/src/page-title.spec.ts |
Adds tests documenting/locking in title resolution rules for single-project, per-view, and dashboard pages. |
.changeset/fix-single-project-page-title.md |
Declares a patch release for the likec4 package describing the title fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
mainbefore creating this PR.pnpm typecheckandpnpm test./changeset-generatorSKILL).