packages/language-server/src/model/__tests__/model-builder.spec.ts (1)

246-266: ⚡ Quick win

Assert the where metadata.group filter outcome explicitly.

Right now this test proves parse/build success, but it doesn’t verify that the view predicate actually filters as intended. Add a view assertion so the regression catches semantic breaks too.

Proposed test assertion

     const model = await buildModel()
     expect(model).toBeDefined()
     expect(model.elements).toMatchObject({
       test: {
         kind: 'system',
         metadata: {
           team: 'team name',
           _group: '_group name',
           group: 'group name',
           other: 'other name',
         },
       },
     })
+    expect(model.views).toHaveProperty('index')
+    expect(model.views['index' as ViewId]!.nodes.map(n => n.id)).toContain('test')

As per coding guidelines: “Aim to cover new features with relevant tests; keep test names descriptive”.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/language-server/src/model/__tests__/model-builder.spec.ts` around
lines 246 - 266, The test currently builds the model with a view filter but
doesn't assert the view's actual contents; add an assertion after buildModel()
that checks the view named "index" (from the "views { view index { include *
where metadata.group is 'group name' } }" snippet) yields only the expected
element(s) — e.g. confirm model.views['index'] (or model.views.index) contains
the "test" element and excludes others — so the predicate is validated; use
buildModel(), model.elements and the view identifier "index" to locate where to
insert the new expectation.