packages/core/src/builder/Builder.ts (1)

876-897: ⚠️ Potential issue | 🟠 Major

Same links regression applies to deployment nodes.

Consistent with the element creation, the deployment node creation has the same issue where links: mapLinks(links) will override spec-defined links with undefined when user doesn't provide links.

Proposed fix

+              const mappedLinks = mapLinks(links)
               b.__addDeployment(
                 exact({
                   id: _id,
                   kind: kind as any,
                   ...spec,
                   title: title ?? nameFromFqn(_id),
                   ...(description && { description: toMarkdownOrString(description) }),
                   ...(summary && { summary: toMarkdownOrString(summary) }),
                   style: exact({
                     icon: icon as IconUrl | undefined,
                     color: color ?? specStyle?.color,
                     shape: shape ?? specStyle?.shape,
                     border: specStyle?.border,
                     opacity: specStyle?.opacity,
                     size: specStyle?.size,
                     padding: specStyle?.padding,
                     textSize: specStyle?.textSize,
                     ...style,
                   }) satisfies ElementStyle,
-                  links: mapLinks(links),
+                  ...(mappedLinks && { links: mappedLinks }),
                   ...props,
                 }) satisfies DeploymentNode,
               )

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/core/src/builder/Builder.ts` around lines 876 - 897, The Deployment
creation call in __addDeployment is unconditionally setting links:
mapLinks(links), which can overwrite spec-provided links with undefined when the
user omits links; update the object construction so links are only assigned if
the incoming links variable is defined (mirror the element creation fix) — e.g.,
conditionally include links: mapLinks(links) instead of always setting it,
ensuring spec.links remains intact; change the DeploymentNode build in
__addDeployment to only spread the mapped links when links is not undefined and
keep the rest of the props unchanged.