packages/core/src/builder/_types.ts (1)

69-69: Extract and reuse a shared tags type alias across exported props.

The same tags?: [Tag, ...Tag[]] shape is duplicated in four exported prop types. Please centralize it into a single alias to avoid drift and keep the API surface easier to maintain.

Proposed refactor

+type TagsProp<Tag> = [Tag, ...Tag[]]

 export type NewElementProps<Tag, Metadata> = {
   title?: string
   summary?: MarkdownOrString | string
   description?: MarkdownOrString | string
   technology?: string
-  tags?: [Tag, ...Tag[]]
+  tags?: TagsProp<Tag>
   metadata?: Metadata
   icon?: string
   ...
 }

 export type NewDeploymentNodeProps<Tag, Metadata> = {
   title?: string
   summary?: MarkdownOrString | string
   description?: MarkdownOrString | string
   technology?: string
-  tags?: [Tag, ...Tag[]]
+  tags?: TagsProp<Tag>
   metadata?: Metadata
   ...
 }

 export type NewViewProps<Tag> = {
   title?: string
   description?: MarkdownOrString | string
-  tags?: [Tag, ...Tag[]]
+  tags?: TagsProp<Tag>
   links?: Array<string | { title?: string; url: string }>
 }

 export type NewRelationProps<Kind, Tag, Metadata> = {
   kind?: Kind
   title?: string
   description?: MarkdownOrString | string
   technology?: string
   notes?: MarkdownOrString | string
-  tags?: [Tag, ...Tag[]]
+  tags?: TagsProp<Tag>
   metadata?: Metadata
   ...
 }

As per coding guidelines, "Agent types and interfaces should be defined separately and reused across the codebase".

Also applies to: 94-94, 117-117, 127-127

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/core/src/builder/_types.ts` at line 69, Create a shared exported
type alias like `Tags = [Tag, ...Tag[]]` and replace the duplicated inline
`tags?: [Tag, ...Tag[]]` occurrences in the four exported prop types with
`tags?: Tags`; update the four prop type declarations that currently use the
inline tuple to reference `Tags` instead, and export the new `Tags` alias so
other modules can reuse it (ensure the alias is declared near the other type
definitions in _types.ts and run type checks to confirm no breaking changes).

packages/core/src/compute-view/element-view/predicates/__test__/wildcard.spec.ts (2)

74-114: Add an imported-element where regression.

The changed unscoped include * where path now walks model.elements() and splits imported vs. project elements, but this spec still covers imports only for bare *. A tagged imported descendant would exercise different logic, so it’s worth pinning with a dedicated case.

Based on learnings, "Applies to **/*.spec.ts : Aim to cover new features with relevant tests; keep test names descriptive".

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In
`@packages/core/src/compute-view/element-view/predicates/__test__/wildcard.spec.ts`
around lines 74 - 114, The test suite lacks a case for an imported-element
matched by an unscoped include '*' with a where clause; add a new spec similar
to the existing "include * where" that uses TestHelper.from(builder.clone()) and
t.processPredicates($rules($include('*', { where: 'tag is `#ui`' }))) but targets
an imported descendant (e.g., an imported element with a tag) to exercise the
split logic in the unscoped include implementation; ensure the new test asserts
the expected elements and connections via t.expect(...).toHaveElements(...) and
t.expect(...).toHaveNoConnections() and give it a descriptive name like "include
* where imported element".

---

159-175: Rename the no matches case.

There is still a #mobile descendant under cloud, so the current title reads like a data contradiction. Calling out “no matching direct children” or the fallback behavior would make failures easier to interpret.

Based on learnings, "Applies to **/*.spec.ts : Aim to cover new features with relevant tests; keep test names descriptive".

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In
`@packages/core/src/compute-view/element-view/predicates/__test__/wildcard.spec.ts`
around lines 159 - 175, Rename the test case description to accurately reflect
that there are no matching direct children under 'cloud' rather than no matches
at all; update the it(...) string currently reading "include * in cloud where
tag is `#mobile` (no matches)" to something like "include * in cloud where tag is
`#mobile` (no matching direct children; matches descendants/fallback)" so the
behavior exercised by TestHelper.from(builder.clone()),
processPredicatesWithScope('cloud', $include('*', { where: 'tag is `#mobile`' }))
and the subsequent expectations (t.expect(...).toHaveElements /
toHaveConnections) is clearly documented.

packages/core/src/compute-view/deployment-view/predicates/__test__/wildcard.filter.spec.ts (1)

85-93: Also assert edges for kind is nd.

This case exercises the new root-only where connection path, but it currently locks in nodes only. Adding the expected edges would protect the behavioral change in WildcardPredicate.include, not just the selection set.

Based on learnings, "Applies to **/*.spec.ts : Aim to cover new features with relevant tests; keep test names descriptive".

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In
`@packages/core/src/compute-view/deployment-view/predicates/__test__/wildcard.filter.spec.ts`
around lines 85 - 93, The test currently asserts only nodes for the
$include('*', { where: 'kind is nd' }) case via
t.expectComputedView(...).toHaveNodes(...); add a complementary assertion that
checks the edges produced by this root-only where connection path by calling
t.expectComputedView($include('*', { where: 'kind is nd' })).toHaveEdges(...)
and list the expected connections (e.g. edges showing prod->prod.infra,
prod->prod.z1 and root-level connections to customer and global) so the spec for
WildcardPredicate.include verifies both the selection set and the resulting
edges.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes