packages/leanix-bridge/src/mapping.ts (1)

45-47: Consider using TypeError for type validation errors.

Per JavaScript conventions and the static analysis hint, type check errors should throw TypeError rather than Error for better semantic clarity.

♻️ Proposed fix

   if (typeof input !== 'object' || Array.isArray(input)) {
-    throw new Error('LeanIX mapping must be a plain object (not an array or primitive)')
+    throw new TypeError('LeanIX mapping must be a plain object (not an array or primitive)')
   }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/leanix-bridge/src/mapping.ts` around lines 45 - 47, The type-check
that currently throws new Error('LeanIX mapping must be a plain object (not an
array or primitive)') should throw a TypeError instead; update the throw in the
input validation branch (the if block checking typeof input !== 'object' ||
Array.isArray(input')) to throw new TypeError with the same message so type
validation errors use the correct Error subclass (locate this in the mapping.ts
validation logic where input is checked).

packages/leanix-bridge/src/mapping.spec.ts (1)

11-47: Good test coverage for the new validation function.

The tests appropriately cover null/undefined passthrough, empty object acceptance, root type validation, unknown key rejection, and non-string value validation for all three record fields.

Consider adding a positive test case for a fully valid config to complement the rejection tests:

💡 Optional: Add valid full config test

     it('accepts empty object', () => {
       expect(parseLeanixMappingInput({})).toEqual({})
     })
+
+    it('accepts valid full config', () => {
+      const validConfig = {
+        factSheetTypes: { system: 'Application' },
+        relationTypes: { default: 'depends on' },
+        metadataToFields: { title: 'name' },
+      }
+      expect(parseLeanixMappingInput(validConfig)).toEqual(validConfig)
+    })

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/leanix-bridge/src/mapping.spec.ts` around lines 11 - 47, Add a
positive unit test that asserts parseLeanixMappingInput returns the expected
normalized object for a fully valid config: create a test in the
describe('parseLeanixMappingInput') block that calls parseLeanixMappingInput
with an object containing valid string-valued factSheetTypes, relationTypes, and
metadataToFields entries and expects the parsed result to equal the same (or
normalized) object; reference the parseLeanixMappingInput symbol and place the
test alongside the existing "accepts empty object" and rejection tests to ensure
a successful round-trip for valid input.