fix: incorrect timeout handling in webServer configuration by zendy199x · Pull Request #2813 · likec4/likec4

zendy199x · 2026-03-28T14:24:39Z

Checklist

I've thoroughly read the latest contribution guidelines.
I've rebased my branch onto main before creating this PR.
My commit messages follow conventional spec
I've added tests to cover my changes (if applicable).
I've verified that all new and existing tests have passed locally for mobile, tablet, and desktop screen sizes.
My change requires documentation updates.
I've updated the documentation accordingly.

changeset-bot · 2026-03-28T14:24:45Z

⚠️ No Changeset found

Latest commit: 1324d71

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-03-28T14:29:44Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4985b542-6bc9-40c8-9035-9a6fae01cc2c

📥 Commits

Reviewing files that changed from the base of the PR and between bd8e4f8 and 1324d71.

📒 Files selected for processing (3)

e2e/playwright.config.ts
e2e/playwright.playground.config.ts
tests/playwright.config.spec.ts

✅ Files skipped from review due to trivial changes (1)

e2e/playwright.playground.config.ts

🚧 Files skipped from review as they are similar to previous changes (2)

e2e/playwright.config.ts
tests/playwright.config.spec.ts

📝 Walkthrough

Walkthrough

Added webServer.timeout: 60 * 1000 to two Playwright configs to increase server startup wait to 60s, and added a Vitest suite that validates Playwright config values including testDir, testIgnore, timeout, retries, reporter, and webServer shape/fields.

Changes

Cohort / File(s)	Summary
Playwright Configuration Updates `e2e/playwright.config.ts`, `e2e/playwright.playground.config.ts`	Added `webServer.timeout: 60 * 1000` to both configs to extend the dev server startup wait time to 60 seconds.
Playwright Configuration Tests `tests/playwright.config.spec.ts`	New Vitest test suite added to assert Playwright config properties: `testDir`, `testIgnore`, `timeout`, `retries` (CI-sensitive), `reporter` (CI vs non-CI), and `webServer` shape and fields (`command`, `port`, `timeout`).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: adding timeout configuration to webServer settings to fix incorrect timeout handling.
Description check	✅ Passed	The pull request description includes all required checklist items, with all boxes appropriately checked, confirming tests were added and documentation was updated.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@tests/playwright.config.spec.ts`:
- Around line 4-54: Tests currently construct configs with defineConfig and
assert the same literals, so they validate defineConfig instead of the real
exported Playwright configs; replace each test to import the actual exported
config object(s) from the Playwright config module (the module that currently
exports your Playwright configs) and assert their properties (testDir,
testIgnore, timeout, retries, reporter, webServer?.command/port/timeout) rather
than building a new config; keep using the same identifiers from the spec
(defineConfig, isCI, config.reporter, config.webServer) as references, adjust
test names to reflect they validate the exported config, and for CI-dependent
assertions ensure isCI is derived or mocked consistently with the production
config.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1be21d1b-45ec-456b-ad98-da15543b23ff

📥 Commits

Reviewing files that changed from the base of the PR and between 1a03286 and bd8e4f8.

📒 Files selected for processing (3)

e2e/playwright.config.ts
e2e/playwright.playground.config.ts
tests/playwright.config.spec.ts

Copilot

Pull request overview

This PR aims to correct Playwright E2E webServer timeout handling by updating the Playwright configuration used to start local servers during E2E runs.

Changes:

Add an explicit timeout to webServer in the main E2E Playwright config.
Add an explicit timeout to webServer in the playground E2E Playwright config.
Add a new spec file intended to assert expected Playwright config values.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File	Description
`tests/playwright.config.spec.ts`	Adds tests intended to validate Playwright config values.
`e2e/playwright.playground.config.ts`	Adds `webServer.timeout` for the playground server startup.
`e2e/playwright.config.ts`	Adds `webServer.timeout` for the main E2E server startup.

Copilot · 2026-03-28T14:30:48Z

+import { defineConfig } from '@playwright/test'
+import { isCI } from 'std-env'


This spec file likely won't run in CI: the root Vitest config only executes the packages/*/vitest.config.ts projects, so tests/playwright.config.spec.ts is excluded. Also, the root workspace package doesn't declare @playwright/test as a dependency, so running this test from the root would fail module resolution unless you move it into the e2e/ workspace (or add the dependency and include this path in Vitest).

Copilot · 2026-03-28T14:30:49Z

+test('playwright config has correct testDir', () => {
+  const config = defineConfig({
+    testDir: 'tests',
+  })
+  expect(config.testDir).toBe('tests')


test/expect are used throughout this file but never imported. If this is intended to be a Vitest spec, import them from vitest; if it's intended to be a Playwright test, import them from @playwright/test.

Copilot · 2026-03-28T14:30:49Z

    command: 'pnpm likec4 start --verbose --no-react-hmr --no-build-webcomponent',
    port: 5173,
    stdout: 'pipe',
+    timeout: 60 * 1000,
    env: {


webServer.timeout defaults to 60_000ms in Playwright Test (v1.56.x). Setting it to 60 * 1000 here does not change behavior, so it likely won't address “timeout handling” issues unless the intention is to increase it (or disable by setting 0).

Copilot · 2026-03-28T14:30:50Z

    command: 'pnpm --filter @likec4/playground dev -- --port 5174',
    port: 5174,
    stdout: 'pipe',
+    timeout: 60 * 1000,
    reuseExistingServer: !isCI,


webServer.timeout defaults to 60_000ms in Playwright Test (v1.56.x). Making it explicit as 60 * 1000 is a no-op; if this PR is meant to fix server-start timeouts, consider increasing this value (or using 0 to disable the startup timeout).

- update tests/playwright.config.spec.ts - address 1 review comment(s) Signed-off-by: Zendy <50132805+zendy199x@users.noreply.github.com>

Copilot AI review requested due to automatic review settings March 28, 2026 14:24

Copilot started reviewing on behalf of zendy199x March 28, 2026 14:25 View session

coderabbitai Bot reviewed Mar 28, 2026

View reviewed changes

Comment thread tests/playwright.config.spec.ts Outdated

Copilot AI reviewed Mar 28, 2026

View reviewed changes

fix: address PR review feedback

1324d71

- update tests/playwright.config.spec.ts - address 1 review comment(s) Signed-off-by: Zendy <50132805+zendy199x@users.noreply.github.com>

zendy199x force-pushed the fix/incorrect-timeout-handling-in-webserver-configurat branch from bd8e4f8 to 1324d71 Compare March 28, 2026 14:49

davydkov enabled auto-merge (squash) April 1, 2026 10:22

davydkov disabled auto-merge April 1, 2026 10:22

davydkov merged commit d46d5ff into likec4:main Apr 1, 2026
14 checks passed

coderabbitai Bot mentioned this pull request May 22, 2026

feat: edit view properties (title, description, tags) #2976

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: incorrect timeout handling in webServer configuration#2813

fix: incorrect timeout handling in webServer configuration#2813
davydkov merged 1 commit into
likec4:mainfrom
zendy199x:fix/incorrect-timeout-handling-in-webserver-configurat

zendy199x commented Mar 28, 2026 •

edited

Loading

Uh oh!

changeset-bot Bot commented Mar 28, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Mar 28, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

❌ Failed checks (1 warning)

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 28, 2026

Uh oh!

Copilot AI Mar 28, 2026

Uh oh!

Uh oh!

Copilot AI Mar 28, 2026

Uh oh!

Copilot AI Mar 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		import { defineConfig } from '@playwright/test'
		import { isCI } from 'std-env'

Uh oh!

Conversation

zendy199x commented Mar 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

changeset-bot Bot commented Mar 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai Bot commented Mar 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

❌ Failed checks (1 warning)

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 28, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Mar 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 28, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

zendy199x commented Mar 28, 2026 •

edited

Loading

changeset-bot Bot commented Mar 28, 2026 •

edited

Loading

coderabbitai Bot commented Mar 28, 2026 •

edited

Loading