Skip to content

fix(diagram): restore hollow rendering for O-version edge markers#2656

Merged
davydkov merged 3 commits into
mainfrom
copilot/fix-edges-marker-o-version
Feb 21, 2026
Merged

fix(diagram): restore hollow rendering for O-version edge markers#2656
davydkov merged 3 commits into
mainfrom
copilot/fix-edges-marker-o-version

Conversation

Copilot AI commented Feb 21, 2026

Copy link
Copy Markdown
Contributor

Description

O-version edge markers (odiamond, oarrow, odot) were rendering solid instead of hollow. Commit 22250c0 changed their fill from var(--likec4-background-color) to context-stroke, removing the background-colored interior that distinguished them from standard markers.

Changes

  • EdgeMarkers.tsx: Reverted fill attribute to var(--likec4-background-color) for:
    • OArrow marker
    • ODiamond marker
    • ODot marker

This restores the hollow appearance where markers have colored strokes with background-colored fills, making them visually distinct from their solid counterparts.

Before: Solid fill (incorrect)
image

After: Hollow with background fill (correct)
image

Checklist

  • I've thoroughly read the latest contribution guidelines.
  • I've rebased my branch onto main before creating this PR.
  • My commit messages follow conventional spec
  • I've added tests to cover my changes (if applicable).
  • I've verified that all new and existing tests have passed locally for mobile, tablet, and desktop screen sizes.
  • My change requires documentation updates.
  • I've updated the documentation accordingly.
Original prompt

This section details on the original issue you should resolve

<issue_title>[Bug] Arrows EdgeMarker O-version not working as expected</issue_title>
<issue_description>Some arrows EdgeMarker allows for two different versions, the standard one (e.g. diamond) and the O-version (e.g. odiamond).

Previously, the O-version resulted in a slightly bigger edgemarker with an "empty" filling.

Image

Now they appear as just slightly bigger version of the standard edgemarker.

Image

Looking at EdgeMarkers.tsx, we can see the code is as following:
stroke="context-stroke" fill="context-stroke"

while before Commit 22250c0 it was:
stroke="context-stroke" fill="var(--likec4-background-color)"

Is it working as intended and if not, can it be reverted?</issue_description>

Comments on the Issue (you are @copilot in this section)

Custom agent used: changeset-generator
Generate changeset based on current branch changes or staged files


🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

@changeset-bot

changeset-bot Bot commented Feb 21, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 0471623

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 19 packages
Name Type
@likec4/diagram Patch
@likec4/playground Patch
likec4 Patch
@likec4/react Patch
@likec4/vscode-preview Patch
likec4-vscode Patch
@likec4/docs-astro Patch
@likec4/style-preset Patch
@likec4/styles Patch
@likec4/config Patch
@likec4/core Patch
@likec4/generators Patch
@likec4/language-server Patch
@likec4/language-services Patch
@likec4/layouts Patch
@likec4/log Patch
@likec4/mcp Patch
@likec4/tsconfig Patch
@likec4/vite-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Co-authored-by: davydkov <824903+davydkov@users.noreply.github.com>
@davydkov davydkov marked this pull request as ready for review February 21, 2026 15:42
Fix O-version edge markers to display as hollow with background fill instead of solid fill. This addresses issue #2634.

Signed-off-by: Denis Davydkov <denis@davydkov.com>
@davydkov davydkov enabled auto-merge (squash) February 21, 2026 15:44
Copilot AI changed the title [WIP] Fix arrows EdgeMarker O-version rendering issue fix(diagram): restore hollow rendering for O-version edge markers Feb 21, 2026
Copilot AI requested a review from davydkov February 21, 2026 15:44
@davydkov davydkov merged commit 7f43ca1 into main Feb 21, 2026
14 checks passed
@davydkov davydkov deleted the copilot/fix-edges-marker-o-version branch February 21, 2026 15:48
@likec4-ci likec4-ci Bot mentioned this pull request Feb 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Arrows EdgeMarker O-version not working as expected

2 participants