Fix compilation errors from Navigation 3 migration#1428
Merged
Conversation
- Add default values to AppListNavKey and GeneralRuleNavKey data classes so they can be instantiated without arguments - Use NavKey instances (with parentheses) instead of bare class references in TopLevelNavItem map, BlockerAppState, and BlockerAppStateTest - Remove extra tab/searchKeyword params from SearchViewModel.Factory to match the 2 @assisted constructor parameters - Pass GeneralRulesViewModel via assisted factory in GeneralRuleEntryProvider - Fix BlockerAppStateTest nested test structure by extracting inner test functions to top-level class methods
- Fix public BlockerApp calling itself recursively instead of the internal overload by passing snackbarHostState parameter - Remove shadowed snackbarHostState variable in internal BlockerApp - Move test assertions outside setContent in BlockerAppStateTest to avoid UncompletedCoroutinesError - Provide LocalSnackbarHostState in SnackbarScreenshotTests
alpha05 flags testOptions.animationsDisabled as InternalAgpApiUsage, which fails the build-logic lint check and blocks all subsequent CI steps including Roborazzi screenshot recording.
This module has no tests. The isIncludeAndroidResources config combined with test dependencies from the convention plugin caused Gradle to fail with failOnNoDiscoveredTests.
…ture impl modules - Add roborazzi plugin and core:screenshotTesting test dependency to all feature impl modules that have screenshot tests - Remove testOptions.unitTests.isIncludeAndroidResources from feature api modules that have no tests (fixes failOnNoDiscoveredTests error) - Add missing @assisted parameters to ViewModel tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AppListNavKeyandGeneralRuleNavKeydata class parameters so they can be instantiated without argumentsAppListNavKey(),GeneralRuleNavKey(),SearchNavKey()) instead of bare class references inTopLevelNavItem,BlockerAppState, andBlockerAppStateTesttab/searchKeywordparams fromSearchViewModel.Factoryto match the 2@Assistedconstructor parametersGeneralRulesViewModelvia assisted factory inGeneralRuleEntryProviderBlockerAppStateTestnested test structure by extracting inner test functions to top-level class methodsTest plan
./gradlew assembleFossDebugbuilds successfully./gradlew testFossDebugUnitTestpasses relevant unit tests