Fix debloater component toggle UI not updating after state change#1356
Merged
Conversation
The debloater screen had a bug where component toggle switches would not update in the UI after enabling/disabling a component, even though the controller successfully changed the component state. This required users to restart the app to see the changes. Root cause: The ViewModel used a continuous flow that would overwrite optimistic UI updates when new data was emitted from the repository. Solution: Refactored DebloaterViewModel to use one-time data loading with .first() similar to RuleDetailViewModel pattern. The init block now calls loadData() once on initialization and when search query changes, instead of continuously collecting from repository flow. This prevents repository emissions from overwriting the optimistic UI updates made during component control operations. Changes: - Modified DebloaterViewModel to use loadData() method with .first() - Added drop(1) to search query collection to avoid duplicate loads - Updated tests to initialize data before ViewModel creation - All unit tests passing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the DebloaterScreen, component toggle switches would not update in the UI after enabling/disabling a component, even though the controller successfully changed the component state. Users had to restart the app to see the changes.
Root Cause
The DebloaterViewModel used a continuous flow collection pattern that would overwrite optimistic UI updates when new data was emitted from the repository. The
initblock had:Solution
Refactored DebloaterViewModel to use one-time data loading with
.first()similar to the RuleDetailViewModel pattern:loadData()methoddrop(1)to search query collection to avoid duplicate loads on initializationThis prevents repository emissions from overwriting the optimistic UI updates made during component control operations.
Testing