Add IFW_PLUS_PM combined controller type#1354
Merged
Merged
Conversation
Add new controller type that combines IFW and PM controllers for dual-layer component blocking. Changes: - Add IFW_PLUS_PM to ControllerType enum and proto - Implement CombinedController that uses both IFW and PM controllers - Update dependency injection to support combined controller - Add controller type selection in Settings UI - Update all repository and worker classes to handle new type Component control logic: - disable: Blocks using both IFW and PM - enable: Enables using both IFW and PM - State check: Returns enabled if EITHER controller reports enabled
9047d0f to
5ed5207
Compare
Allow callers to override the default controller type from user preferences. Changes: - Add optional controllerType parameter to controlComponent and batchControlComponent methods - Update ComponentRepository interface - Update LocalComponentRepository to use provided type or fall back to userData - Update FakeComponentRepository and TestComponentRepository test implementations When controllerType is provided, it overrides the user's default controller. When null, behavior remains unchanged (uses userData.controllerType).
Add missing combinedController parameter and test case for IFW_PLUS_PM type. Changes: - Add combinedController instance to test class - Pass combinedController to GetControllerUseCase constructor - Add test case for IFW_PLUS_PM controller type - Update sequential flow test to include IFW_PLUS_PM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IFW_PLUS_PMthat combines IFW and PM controllers for dual-layer component blockingCombinedControllerthat uses both IFW and PM controllers simultaneouslyKey Changes
IFW_PLUS_PMtoControllerTypeenum and protoCombinedControllerimplementingIControllerinterface@CombinedControlqualifier and bindingsGetControllerUseCaseto provide combined controllerControl Logic
true(enabled) if EITHER controller reports enabled,false(disabled) only if BOTH are disabledTesting
./gradlew assembleFossDebugCloses #1282