Skip to content

Refactor sort bottomSheet module#1172

Merged
lihenggui merged 26 commits into
mainfrom
bottomSheet
Mar 20, 2025
Merged

Refactor sort bottomSheet module#1172
lihenggui merged 26 commits into
mainfrom
bottomSheet

Conversation

@juliewww

@juliewww juliewww commented Mar 18, 2025

Copy link
Copy Markdown
Collaborator

name: Pull request
about: Create a pull request
label: 'triage me'

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way
    we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter
    pass (./gradlew --init-script gradle/init.gradle.kts spotlessApply to automatically apply
    formatting)
  • Appropriate docs were updated (if necessary)

Is this your first Pull Request?

  • Run ./tools/setup.sh
  • Import the code formatting style as explained in the setup script.

Fixes #<issue_number_goes_here> 🦕

juliewww and others added 22 commits March 18, 2025 14:49
… to reflect new package structure and update references to ComponentSortBottomSheetUI
<string name="feature_applist_priority">Prioridade</string>
<string name="feature_applist_name">Nome</string>
<string name="feature_applist_install_date">Data de instalação</string>
<string name="feature_applist_last_updated">Ultima Atualização</string>

Check warning

Code scanning / Android Lint

Spelling error

"Ultima" is a common misspelling; did you mean "Última"?
<string name="feature_applist_order">Order</string>
<string name="feature_applist_ascending">Ascending</string>
<string name="feature_applist_descending">Descending</string>
<string name="feature_applist_priority">Priority</string>

Check warning

Code scanning / Android Lint

Unused resources

The resource R.string.feature_applist_priority appears to be unused
<string name="feature_applist_ascending">Ascending</string>
<string name="feature_applist_descending">Descending</string>
<string name="feature_applist_priority">Priority</string>
<string name="feature_applist_name">Name</string>

Check notice

Code scanning / Android Lint

Incomplete translation

"feature_applist_name" is not translated in "fr" (French)
@lihenggui lihenggui merged commit 271953c into main Mar 20, 2025
@lihenggui lihenggui deleted the bottomSheet branch March 20, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants