Skip to content

Dashicons - Custom Icons for Custom Blocks#460

Merged
krugazul merged 4 commits into2.0-beta-3from
Dashicons
Dec 19, 2024
Merged

Dashicons - Custom Icons for Custom Blocks#460
krugazul merged 4 commits into2.0-beta-3from
Dashicons

Conversation

@Justinabes007
Copy link
Copy Markdown
Contributor

@Justinabes007 Justinabes007 commented Dec 17, 2024 •
edited by github-actions bot
Loading

Dashicons - Custom Icons for Custom Blocks

This PR addresses the changes described in Issue #409. The following updates have been implemented:

Commit 1: 35f2511

Assigned Dashicons to Editor Views to differentiate the different Tour Operator Custom Icons for Custom Blocks created.

Commit 2: f384375

Identified hard-coded Image URLs for front-end icons, replaced and updated with the same icons linked to Tour Operator plugin Assets.

These changes were made to address the issues outlined in the linked GitHub issue. Please review the updates and provide feedback or approve the changes.

Close #409

Summary by CodeRabbit

  • Style: Updated and enhanced the visual representation of various custom blocks in the Tour Operator plugin. This includes the introduction and updates to icons such as "info-outline", "admin-plugins", "bank", "food", "cloud", "car", "admin-users", "insert", "shield", "id-alt", "clipboard", "admin-site-alt", 'money-alt', 'airplane', 'calendar-alt', 'plus-alt', 'dismiss', 'insert-after', 'admin-site-alt3', 'admin-home', 'palmtree', 'admin-site', and 'list-view'.
  • Chore: Replaced hardcoded image URLs with dynamic links to plugin assets, improving maintainability.

@Justinabes007 Justinabes007 added this to the 2.1.0 milestone Dec 17, 2024
@Justinabes007 Justinabes007 self-assigned this Dec 17, 2024
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Dec 17, 2024 •
edited
Loading

Warning

CodeRabbit GitHub Action detected

The repository is using both CodeRabbit Pro and CodeRabbit Open Source (via GitHub Actions), which is not recommended as it may lead to duplicate comments and extra noise. Please remove the CodeRabbit GitHub Action.

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 17, 2024 •
edited
Loading

Image description CodeRabbit

Walkthrough

This update introduces and refreshes the icons for various custom blocks in the Tour Operator plugin. The changes are purely aesthetic, enhancing the visual representation of the blocks within the editor interface. Hardcoded image URLs have been updated to use plugin asset links, improving maintainability.

Changes

Files Summary
assets/js/blocks/destination.js, assets/js/blocks/general.js, assets/js/blocks/query-loops.js, assets/js/blocks/tour.js, assets/js/blocks/accommodation.js Icons like "info-outline", "admin-plugins", "bank", "food", "cloud", "car", "admin-users", "insert", "shield", "id-alt", "clipboard", "admin-site-alt", 'money-alt', 'airplane', 'calendar-alt', 'plus-alt', 'dismiss', 'insert-after', 'admin-site-alt3', 'admin-home', 'palmtree', 'admin-site', and 'list-view' have been assigned, replaced or updated. Hardcoded image URLs were updated to use URLs linked to plugin assets.

🐰🎉

With new icons, our code takes flight,

In the editor's interface, a delightful sight.

No more hardcoded paths we trace,

Now using plugin assets, a better space.

Celebrate these changes, oh so bright,

For they make our plugin a shining light! 🌟

Uplevel your code reviews with CodeRabbit Pro

CodeRabbit Pro

If you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects.

github-actions[bot]
github-actions bot reviewed Dec 17, 2024
View reviewed changes
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Commits Files that changed from the base of the PR and between ebc5c22 and d4abc48 commits.
Files selected (4)
  • assets/js/blocks/destination.js (12)
  • assets/js/blocks/general.js (6)
  • assets/js/blocks/query-loops.js (14)
  • assets/js/blocks/tour.js (19)
Files ignored due to filter (15)
  • assets/img/blocks/Typelocation-icon.png
  • assets/img/blocks/accommodation-rooms-icon.png
  • assets/img/blocks/accommodation-type.png
  • assets/img/blocks/booking-validity.svg
  • assets/img/blocks/check-in-check-out-time.svg
  • assets/img/blocks/duration.png
  • assets/img/blocks/friendly-TO-icon.png
  • assets/img/blocks/group-size.svg
  • assets/img/blocks/map-TO-icon.png
  • assets/img/blocks/minimum-child-age-icon.svg
  • assets/img/blocks/rating-icon-TO.png
  • assets/img/blocks/single-supplement-icon.svg
  • assets/img/blocks/special-interests-icon.svg
  • assets/img/blocks/spoken-languages.png
  • assets/img/blocks/wetu-map-figme-prototype-image.png
Files skipped from review due to trivial changes (3)
  • assets/js/blocks/destination.js
  • assets/js/blocks/general.js
  • assets/js/blocks/tour.js
Review comments generated (14)
  • Review: 0
  • LGTM: 14
Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

github-actions[bot]
github-actions bot reviewed Dec 18, 2024
View reviewed changes
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Commits Files that changed from the base of the PR and between d4abc48 and ba541e1 commits.
Files selected (1)
  • assets/js/blocks/accommodation.js (23)
Files skipped from review due to trivial changes (1)
  • assets/js/blocks/accommodation.js
Review comments generated (0)
  • Review: 0
  • LGTM: 0
Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

@krugazul krugazul merged commit 7d00899 into 2.0-beta-3 Dec 19, 2024
@krugazul krugazul deleted the Dashicons branch December 19, 2024 12:30
@ZaredRogers ZaredRogers linked an issue Jan 9, 2025 that may be closed by this pull request
Dashicons - Custom Icons for Custom Blocks #409
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@krugazul krugazul krugazul approved these changes

@ZaredRogers ZaredRogers Awaiting requested review from ZaredRogers

Assignees

@Justinabes007 Justinabes007

Labels

comp:block-patterns Patterns library/registration comp:block-variations Block variations

Projects

Tour Operator
Status: ✅ Done

Milestone

v2.1.0

Development

Successfully merging this pull request may close these issues.

Dashicons - Custom Icons for Custom Blocks

2 participants

@Justinabes007 @krugazul