fix: Add null safety checks for meta attributes in slotfills (#762)

tibiii · web-flow · commit b8b95989b3f1 · 2025-11-13T15:48:02.000+02:00
* Update slotfills with additional checks for meta attributes, rename vars

* Add jsdoc comments and text domain for translated strings

* Remove unused useState import and add checks for post editing context before showing the toggles
diff --git a/build/slotfills.asset.php b/build/slotfills.asset.php
@@ -1 +1 @@
-<?php return array('dependencies' => array(), 'version' => '2e9554884f0c0233f177');
+<?php return array('dependencies' => array(), 'version' => '8640506d113757c694bd');
diff --git a/build/slotfills.js b/build/slotfills.js
diff --git a/src/js/blocks/slotfills.js b/src/js/blocks/slotfills.js
@@ -1,50 +1,74 @@
-( function ( wp ) {
+(function (wp) {
     const { registerPlugin } = wp.plugins;
     const { PluginPostStatusInfo } = wp.editPost;
     const { ToggleControl } = wp.components;
     const { useSelect, useDispatch } = wp.data;
-    const { createElement, useState } = wp.element;
+    const { createElement } = wp.element;
     const i18n = window.wp.i18n;
 
-    // Custom Sticky Post Toggle Component
+    /**
+     * Component for toggling featured status of a post.
+     *
+     * @since 2.1.0
+     * @return {Element} The toggle control element.
+     */
     const StickyToggle = () => {
-        const { editPost } = useDispatch( 'core/editor' );
-        const handleChange = ( newChecked ) => {
-            editPost( { meta: { featured: newChecked } } );
+        const { editPost } = useDispatch('core/editor');
+        const handleChange = (newChecked) => {
+            editPost({ meta: { featured: newChecked } });
         };
 
-        const isSticky = useSelect( function ( select ) {
-            return select( 'core/editor' ).getEditedPostAttribute( 'meta' )
-                .featured;
-        }, [] );
+        const isSticky = useSelect(function (select) {
+            const meta = select('core/editor').getEditedPostAttribute('meta');
+            return meta?.featured || false;
+        }, []);
 
-        return createElement( ToggleControl, {
-            label: i18n.__( 'Featured' ),
+        return createElement(ToggleControl, {
+            label: i18n.__('Featured', 'tour-operator'),
             checked: isSticky,
             onChange: handleChange,
-        } );
+        });
     };
 
-    // Custom Disable Single Toggle Component
+    /**
+     * Component for toggling the disable single post view setting.
+     *
+     * @since 2.1.0
+     * @return {Element} The toggle control element.
+     */
     const DisableSingleToggle = () => {
-        const { editPost } = useDispatch( 'core/editor' );
-        const handleChange = ( newChecked ) => {
-            editPost( { meta: { disable_single: newChecked } } );
+        const { editPost } = useDispatch('core/editor');
+        const handleChange = (newChecked) => {
+            editPost({ meta: { disable_single: newChecked } });
         };
 
-        const isSticky = useSelect( function ( select ) {
-            return select( 'core/editor' ).getEditedPostAttribute( 'meta' )
-                .disable_single;
-        }, [] );
+        const isDisabled = useSelect(function (select) {
+            const meta = select('core/editor').getEditedPostAttribute('meta');
+            return meta?.disable_single || false;
+        }, []);
 
-        return createElement( ToggleControl, {
-            label: i18n.__( 'Disable Single' ),
-            checked: isSticky,
+        return createElement(ToggleControl, {
+            label: i18n.__('Disable Single', 'tour-operator'),
+            checked: isDisabled,
             onChange: handleChange,
-        } );
+        });
     };
 
     const LsxToStatusPlugin = function () {
+        // Check if we're in a post editing context (not template editor)
+        const isEditingPost = useSelect(function (select) {
+            const currentPost = select('core/editor')?.getCurrentPost?.();
+            const postType = select('core/editor')?.getCurrentPostType?.();
+
+            // We're editing a post if we have a current post with an ID and it's not a template
+            return currentPost && currentPost.id && postType !== 'wp_template';
+        }, []);
+
+        // Only show toggles when editing a post (not template)
+        if (!isEditingPost) {
+            return null;
+        }
+
         return createElement(
             PluginPostStatusInfo,
             {
@@ -61,21 +85,21 @@
                     {
                         className: 'toggle-row',
                     },
-                    createElement( StickyToggle )
+                    createElement(StickyToggle)
                 ),
                 createElement(
                     'div',
                     {
                         className: 'toggle-row',
                     },
-                    createElement( DisableSingleToggle )
+                    createElement(DisableSingleToggle)
                 )
             )
         );
     };
 
-    registerPlugin( 'lsx-to-status-plugin', {
+    registerPlugin('lsx-to-status-plugin', {
         render: LsxToStatusPlugin,
         icon: null,
-    } );
-} )( window.wp );
+    });
+})(window.wp);

Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-<?php return array('dependencies' => array(), 'version' => '2e9554884f0c0233f177');`
	`1`	`+<?php return array('dependencies' => array(), 'version' => '8640506d113757c694bd');`