Skip to content

Validate UTF-8 description and empty route hints when parsing BOLT-11 invoices#9993

Merged
ellemouton merged 5 commits intolightningnetwork:masterfrom
MPins:issue-9904-9915
Aug 4, 2025
Merged

Validate UTF-8 description and empty route hints when parsing BOLT-11 invoices#9993
ellemouton merged 5 commits intolightningnetwork:masterfrom
MPins:issue-9904-9915

Conversation

@MPins
Copy link
Copy Markdown
Contributor

@MPins MPins commented Jun 25, 2025 •
edited by saubyk
Loading

Fixes #9904
Fixes #9915

Validate UTF-8 description and empty route hints when parsing BOLT-11 invoices.

Steps to Test

See the PR unit tests.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Jun 25, 2025

Important

Review skipped

Auto reviews are limited to specific labels.

🏷️ Labels to auto review (1)
  • llm-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@MPins MPins force-pushed the issue-9904-9915 branch from ec8a538 to 402f364 Compare June 25, 2025 04:40
@saubyk saubyk added this to lnd v0.20 Jun 26, 2025
@saubyk saubyk added this to the v0.20.0 milestone Jun 26, 2025
@saubyk saubyk moved this to In progress in lnd v0.20 Jun 26, 2025
@MPins
Copy link
Copy Markdown
Contributor Author

MPins commented Jul 7, 2025

/gemini review

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jul 7, 2025
View reviewed changes
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds validation for non-UTF-8 descriptions and empty route hints in BOLT-11 invoice parsing, along with corresponding unit tests. I've added suggestions to improve the correctness and clarity of the new test cases.

@MPins MPins force-pushed the issue-9904-9915 branch 2 times, most recently from f7527b7 to 052f259 Compare July 8, 2025 22:17
GustavoStingelin
GustavoStingelin approved these changes Jul 10, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@GustavoStingelin GustavoStingelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

yyforyongyu
yyforyongyu reviewed Jul 14, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@yyforyongyu yyforyongyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Only a few nits.

@MPins MPins force-pushed the issue-9904-9915 branch 4 times, most recently from 569c8e1 to c91033a Compare July 14, 2025 20:24
@MPins MPins requested a review from yyforyongyu July 14, 2025 20:58
@MPins
Copy link
Copy Markdown
Contributor Author

MPins commented Jul 14, 2025

@yyforyongyu thanks for the review. Comments addressed.

yyforyongyu
yyforyongyu approved these changes Jul 15, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@yyforyongyu yyforyongyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🏄

@lightninglabs-deploy
Copy link
Copy Markdown
Collaborator

lightninglabs-deploy commented Jul 29, 2025

@MPins, remember to re-request review from reviewers when ready

@yyforyongyu
Copy link
Copy Markdown
Member

yyforyongyu commented Jul 31, 2025

missing a rebase, and cc @saubyk for assigning another reviewer, this PR is very small and should be easy to review.

@saubyk saubyk requested a review from ellemouton July 31, 2025 14:24
@MPins MPins force-pushed the issue-9904-9915 branch from c91033a to d00c6f9 Compare July 31, 2025 14:26
@MPins
Copy link
Copy Markdown
Contributor Author

MPins commented Jul 31, 2025

missing a rebase, and cc @saubyk for assigning another reviewer, this PR is very small and should be easy to review.

Rebased! Thanks!

ellemouton
ellemouton reviewed Aug 1, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@ellemouton ellemouton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! Thanks for this 🙏

One main comment re the test assertion, other than that LGTM

@MPins MPins force-pushed the issue-9904-9915 branch from d00c6f9 to 341baef Compare August 1, 2025 16:47
@MPins MPins requested a review from ellemouton August 1, 2025 17:33
@MPins
Copy link
Copy Markdown
Contributor Author

MPins commented Aug 1, 2025

looks good! Thanks for this 🙏

One main comment re the test assertion, other than that LGTM

Thank you @ellemouton. Comments addressed 👍

@MPins MPins force-pushed the issue-9904-9915 branch from 341baef to 2815d49 Compare August 1, 2025 20:09
@ellemouton ellemouton merged commit 8f94929 into lightningnetwork:master Aug 4, 2025
37 of 39 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in lnd v0.20 Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yyforyongyu yyforyongyu yyforyongyu approved these changes

@ellemouton ellemouton ellemouton approved these changes

+2 more reviewers

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

@GustavoStingelin GustavoStingelin GustavoStingelin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@MPins MPins

Labels

None yet

Projects

lnd v0.20
Status: Done

Milestone

v0.20.0

6 participants

@MPins @lightninglabs-deploy @yyforyongyu @ellemouton @GustavoStingelin @saubyk