-
Notifications
You must be signed in to change notification settings - Fork 2.2k
[16] graph/db: SQL closed SCIDs table and last few methods #9971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16] graph/db: SQL closed SCIDs table and last few methods #9971
Conversation
|
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
8f7ad86 to
81744fd
Compare
81744fd to
f0fdf5a
Compare
f0fdf5a to
4d55164
Compare
4d55164 to
3f6e8fe
Compare
guggero
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
bhandras
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
3f6e8fe to
c5d3d77
Compare
And run `TestAddEdgeProof` against the SQL backends.
Just to be very sure that we don't miss a valid ID.
c5d3d77 to
daf6a08
Compare
|
cc @guggero for override merge 🙏 check-commits is failing due to out-of-disk-space error |
In this PR, we do a few things:
closed_scidindex. This lets us then implement the following methods:PutClosedScid,IsClosedScidForEachChannelCacheable,AddEdgeProof,GraphSessionPart of #9795
See #9932 for the full picture that we are aiming at