graph/db: only fetch required info for graph cache population #9923

ellemouton · 2025-06-09T10:35:55Z

In this PR, we adjust the various methods of the GraphCache such that they all only take the models.Cached* versions
of various types (namely CachedEdgeInfo and CachedEdgePolicy).
This then allows us to implement a new ForEachChannelCacheable method which only requires the
DB layer to fetch the info needed to construct the cache types. This will be useful when we add the SQL version
of the graph store so that we can reduce the number of DB round trips.

Part of #9795

coderabbitai · 2025-06-09T10:36:01Z

Important

Review skipped

Auto reviews are limited to specific labels.

🏷️ Labels to auto review (1)

llm-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

ziggie1984

Looks good 🫡, had some minor comments.

graph/db/graph_cache_test.go

graph/db/models/cached_edge_info.go

graph/db/graph.go

graph/db/kv_store.go

bhandras

LGTM 🎉

graph/db/models/cached_edge_policy.go

graph/db/kv_store.go

ellemouton

Thanks for the review yall! 🙏 updated.

Cool - just waiting on the second review of #9897, then we can merge that and rebase this one on master & merge (after 2nd approval here too) 👍

graph/db/models/cached_edge_policy.go

graph/db/graph_cache_test.go

graph/db/graph.go

graph/db/kv_store.go

Remove the unused UpdateChannel method.

Remove the redundant "edge2" param and rather use the "policy" param to derive the boolean.

Update the GraphCache.UpdatePolicy method to take a `models.CachedEdgePolicy` instead of a `models.ChannelEdgePolicy`. Doing this will allow us later on to only fetch the necessary info for populating the CachedEdgePolicy when we are populating the cache via UpdatePolicy.

So that the call-sites of this method dont necessarily need to fetch all the data required to populate the full ChannelEdgePolicy.

Define a new CachedEdgeInfo type and let the graph cache's AddChannel use this. This will let us later on (for the SQL impl of the graph db) only load from the DB what we actually need for the graph cache.

Implement ForEachChannelCacheable which is like ForEachChannel but its call-back takes the cached versions of channel info & policies. This is then used during graph cache population. This will be useful once the SQL implementation is added so that we can reduce the number of DB trips on cache population.

ellemouton · 2025-06-11T04:42:38Z

check-commits failing due to "out of disk space" error but passes locally

ziggie1984

LGTM

ellemouton added this to the v0.20.0 milestone Jun 9, 2025

ellemouton self-assigned this Jun 9, 2025

ellemouton added graph performance labels Jun 9, 2025

ellemouton force-pushed the graphCache branch 2 times, most recently from 8aa80d0 to 2fbba94 Compare June 9, 2025 13:30

ellemouton requested review from bhandras and ziggie1984 June 10, 2025 06:13

ziggie1984 reviewed Jun 10, 2025

View reviewed changes

graph/db/graph_cache_test.go Show resolved Hide resolved

graph/db/models/cached_edge_info.go Outdated Show resolved Hide resolved

graph/db/graph.go Show resolved Hide resolved

graph/db/kv_store.go Show resolved Hide resolved

bhandras approved these changes Jun 10, 2025

View reviewed changes

graph/db/models/cached_edge_policy.go Outdated Show resolved Hide resolved

graph/db/kv_store.go Show resolved Hide resolved

ellemouton force-pushed the graphCache branch from 2fbba94 to b947f81 Compare June 10, 2025 13:45

ellemouton commented Jun 10, 2025

View reviewed changes

ellemouton requested a review from ziggie1984 June 10, 2025 13:49

ellemouton changed the base branch from elle-inboundFeeTLV to master June 10, 2025 18:09

ellemouton added 8 commits June 10, 2025 20:10

graph/db: remove unused GraphCache method

2e716bf

Remove the unused UpdateChannel method.

graph/db: simplify GraphCache.UpdatePolicy signature

0816645

Remove the redundant "edge2" param and rather use the "policy" param to derive the boolean.

graph/db: add CachedEdgePolicy helpers

f95588c

graph/db: let GraphCache.AddChannel take cached edge polies

3ea86bf

So that the call-sites of this method dont necessarily need to fetch all the data required to populate the full ChannelEdgePolicy.

graph/db: let GraghCache.AddChannel take CachedEdgeInfo

3069a67

Define a new CachedEdgeInfo type and let the graph cache's AddChannel use this. This will let us later on (for the SQL impl of the graph db) only load from the DB what we actually need for the graph cache.

docs: update release notes

6fb90c8

ellemouton force-pushed the graphCache branch from b947f81 to 6fb90c8 Compare June 10, 2025 18:10

ziggie1984 approved these changes Jun 11, 2025

View reviewed changes

Roasbeef merged commit 07f65b5 into lightningnetwork:master Jun 11, 2025
67 of 71 checks passed

ellemouton mentioned this pull request Jun 11, 2025

[epic]: graph db: SQL implementation & migration #9795

Closed

84 tasks

graph/db: only fetch required info for graph cache population #9923

graph/db: only fetch required info for graph cache population #9923

Uh oh!

Conversation

ellemouton commented Jun 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Jun 9, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

ziggie1984 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bhandras left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ellemouton left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ellemouton commented Jun 11, 2025

Uh oh!

ziggie1984 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ellemouton commented Jun 9, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)