walletrpc: Fix SignPsbt for NP2WKH inputs #6687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roasbeef
approved these changes
Jun 30, 2022
lnwallet/btcwallet/psbt.go
Outdated
Member
There was a problem hiding this comment.
Great commit message, this makes a lot of sense in retrospect.
lntest/itest/lnd_psbt_test.go
Outdated
Member
There was a problem hiding this comment.
Nice expansion of our test coverage here 👍
ab82b5d to
ad299ba
Compare
Fixes lightningnetwork#6626. If either of the two fields FinalScriptSig or FinalScriptWitness is set on an input of a PSBT then that results in most of the fields of that input not to be serialized in the packet anymore, since the input is considered to be complete. But because a signer isn't supposed to set any of the Final* fields, this was wrong from the beginning. Only the finalizer will set those fields.
ad299ba to
719fd58
Compare
bhandras
approved these changes
Jun 30, 2022
Collaborator
bhandras
left a comment
There was a problem hiding this comment.
LGTM, very nice and clean PR. Only reviewed from the code quality POV as I'm not very knowledgeable about psbt construction.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6626.