Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: lightningnetwork/lnd
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: bottlepay/lnd
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: failure-message-test-vector
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 6 commits
  • 12 files changed
  • 1 contributor

Commits on Oct 26, 2022

  1. htlcswitch/test: more realistic mock encryption 

    This mock is used in the switch test TestUpdateFailMalformedHTLCErrorConversion.
But because the mock isn't very realistic, it doesn't detect problems
in the handling of malformed failures in the link.
    @joostjager
    joostjager committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    93daaf9 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2022

  1. lnwire: verify failure message length 

    Adds extra checks to make sure the failure message
is well-formed.
    @joostjager
    joostjager committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    24a9e9b View commit details
    Browse the repository at this point in the history

  2. link: enforce minimum failure reason length

    @joostjager
    joostjager committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    23bc059 View commit details
    Browse the repository at this point in the history

  3. lnwire: add extra opaque data to FailIncorrectDetails

    @joostjager
    joostjager committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    733d753 View commit details
    Browse the repository at this point in the history

  4. lnwire: allow longer failure messages 

    This fixes an incompatibility where lnd enforces a strict 256 byte
failure message, where as the spec sets this only as the recommended
length.
    @joostjager
    joostjager committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    c50f9ee View commit details
    Browse the repository at this point in the history

  5. Add test vector generator

    @joostjager
    joostjager committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    bcd0c2c View commit details
    Browse the repository at this point in the history
Loading