Support single macaroon for lnd#334
Merged
guggero merged 2 commits intolightninglabs:masterfrom Feb 5, 2021
Merged
Conversation
Fixes lightninglabs#299 by allowing only one macaroon to be specified in the --lnd.macaroonpath config option/command line flag.
carlaKC
approved these changes
Feb 5, 2021
| Docker is very flexible so you can use that information however you choose. This guide isn't meant to be prescriptive. | ||
|
|
||
|
|
||
| ### Example: Running loopd |
Contributor
Author
There was a problem hiding this comment.
It was a weird non-breaking space that probably got in there through copy/paste. My IDE showed it so I removed it.
bhandras
approved these changes
Feb 5, 2021
| // Make sure only one of the macaroon options is used. | ||
| switch { | ||
| case cfg.Lnd.MacaroonPath != "" && cfg.Lnd.MacaroonDir != "": | ||
| return fmt.Errorf("use --lnd.macaroonpath only") |
Member
There was a problem hiding this comment.
nit: Shouldn't this be either macaroondir or macaroonpath?
Contributor
Author
There was a problem hiding this comment.
Yes. But since the macaroondir is deprecated, this error is a bit clearer what the action should be. And it's the exact same commit that I added to Pool, so at least the error messages will be the same :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #299 by allowing only one macaroon to be specified in the
--lnd.macaroonpath config option/command line flag.
Pull Request Checklist
release_notes.mdif your PR contains major features, breaking changes or bugfixes