Merged
Conversation
Fixes lightninglabs#84. Allows faraday to only use the readonly.macaroon (or a custom baked one) to connect to lnd instead of needing to copy all macaroons (including the subserver ones).
We need to move the call that sets all log levels out of the config validation. Otherwise this will overwrite all subsystem log levels in LiT where we call the faraday.ValidateConfig() function but have already set up our loggers. At the same time we remove the unnecessary global logWriter variable.
|
Just out of curiosity, what would be the least permissions (ie. which specific endpoints does it use from lnd) for this? |
Contributor
Author
|
There is no definitive list yet. From a quick glance at where the We're planning on adding something like "macaroon recipes" to Faraday, Loop and Pool so you can bake exactly the macaroon you need. But for that to be as dynamic as possible, we first need to figure out a way to determine this list at build time somehow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #84.
Allows faraday to only use the readonly.macaroon (or a custom baked one)
to connect to lnd instead of needing to copy all macaroons (including
the subserver ones).
We also fix an issue that popped up during testing of the latest LiT release where the faraday log level would overwrite any other log level set beforehand.
Pull Request Checklist
release_notes.mdif your PR contains major features, breaking changes or bugfixes