go.mod: update lnd to v0.18.3-beta#161
Merged
guggero merged 1 commit intolightninglabs:masterfrom Sep 20, 2024
Merged
Conversation
guggero
reviewed
Sep 20, 2024
Collaborator
guggero
left a comment
There was a problem hiding this comment.
Looks good, thanks for the update. Just one comment about the command descriptions that need to be re-generated.
| // lndVersion is the current version of lnd that we support. This is | ||
| // shown in some commands that affect the database and its migrations. | ||
| lndVersion = "v0.18.0-beta" | ||
| lndVersion = "v0.18.3-beta" |
Collaborator
There was a problem hiding this comment.
We should run make docs after changing this value.
Contributor
Author
There was a problem hiding this comment.
Fixed!
Also updated the comments in go.mod and cmd/chantools/root.go adding the instruction to run make docs after changing LND version.
Also updated versions of modules inside LND repo (lnd/sqldb etc) to the versions used by v0.18.3-beta. Fixed few build errors caused by changes in APIs. Ran "make docs" and updated the comments in go.mod and cmd/chantools/root.go adding the instruction to run "make docs" after changing LND version.
384ee41 to
223cc02
Compare
guggero
approved these changes
Sep 20, 2024
| // cmd/chantools/root.go. | ||
| github.com/lightningnetwork/lnd v0.18.0-beta.1 | ||
| github.com/lightningnetwork/lnd/kvdb v1.4.8 | ||
| // cmd/chantools/root.go and run "make docs". |
| --maxcsvlimit uint16 maximum CSV limit to use (default 2016) | ||
| --maxnumchanstotal uint16 maximum number of keys to try, set to maximum number of channels the local node potentially has or had (default 500) | ||
| --maxnumchanupdates uint maximum number of channel updates to try, set to maximum number of times the channel was used (default 500) | ||
| --maxnumchanupdates uint maximum number of channel updates to try, set to maximum number of times the channel was used (default 1000) |
Collaborator
There was a problem hiding this comment.
Looks like I forgot to update the docs a couple of times.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also updated versions of modules inside LND repo (lnd/sqldb etc) to the versions used by v0.18.3-beta.
Fixed few build errors caused by changes in APIs.