Rename a's keys as local's keys and b's keys as remote's keys#633
Merged
TheBlueMatt merged 8 commits intolightningdevkit:masterfrom Sep 14, 2020
Merged
Rename a's keys as local's keys and b's keys as remote's keys#633TheBlueMatt merged 8 commits intolightningdevkit:masterfrom
TheBlueMatt merged 8 commits intolightningdevkit:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Downstreaming this while working on anchor, follow-up of #613. This is an attempt to make keys variable names less confusing based on script semantic as an invariant.
Variables should be named according to the script semantic which is
an invariant with regards to generating a local or remote commitment
transaction.
I.e a local_delayed_payment key will always offer to the owner
of the commitment transaction to be paid back after a given delay.