Add an async resolution option to ChainAccess::get_utxo#1980
Merged
wpaulino merged 16 commits intolightningdevkit:mainfrom Feb 11, 2023
Merged
Add an async resolution option to ChainAccess::get_utxo#1980wpaulino merged 16 commits intolightningdevkit:mainfrom
ChainAccess::get_utxo#1980wpaulino merged 16 commits intolightningdevkit:mainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For those operating in an async environment, requiring
ChainAccess::get_utxoreturn information about the requested UTXOsynchronously is incredibly painful. Requesting information about a
random UTXO is likely to go over the network, and likely to be a
rather slow request.
Thus, here, we change the return type of
get_utxoto have both asynchronous and asynchronous form. The asynchronous form requires
the user construct a
AccessFuturewhich theycloneand passback to us. Internally, an
AccessFuturehas anArcto thechannel_announcementmessage which we need to process. When theuser completes their lookup, they call
resolveon theirAccessFuturewhich we pull thechannel_announcementfrom andthen apply to the network graph.
Fixes #1975.