Add flag to disable broadcasting when it's dangerous due to information loss#1593
Closed
QPotato wants to merge 10 commits intolightningdevkit:mainfrom
Closed
Add flag to disable broadcasting when it's dangerous due to information loss#1593QPotato wants to merge 10 commits intolightningdevkit:mainfrom
QPotato wants to merge 10 commits intolightningdevkit:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work in progress PR. The functionality should be ready, but I'm still figuring out how to write tests for this. I'm opening the PR to run CI and use it as reference to ask questions about the tests on the issue.This PR adds a new field to
ChannelMonitorto track when a channel was force closed withshould_broadcast: false. We then use this flag to disabled automatic braodcasting of the latest holder commitment transaction in cases where doing so could be dangerous due to missing information. In particular, adding this solves the case where the transaction would have been broadcast on deserialization of the monitor.I also fixed some minor typos I found on docstrings while reading through the code.
Closes #1563