@TheBlueMatt I'm trying to work on this issue alongside moving HTLC-tracking to ChannelManager as per (2) in this comment: #1643 (comment)

I noticed we can derive most information about inflight payments by looking into Channels that ChannelManager has since we currently use HTLCSources from it to send PaymentPathSuccessful/Failure events to InvoicePayer.

I have a few questions that came out of my investigation so far:

In the Channel struct, it appears that we track HTLCSources in various places, notably in monitor_pending_failures and monitor_pending_finalized_fulfills -- can we treat them as disjoint sets? If so, is their union representative of all the inflight HTLCs at any moment for a channel?
Do we consider HTLCs in holding cells as inflight?

Additionally, at a higher level: what is the current thinking around (1) an ideal API for exposing pending payments to users and (2) how to track inflight HTLCs in ChannelManager?

I believe the @jkczyz mentioned at some point for (2) to consider either creating a new trait or adding InflightHtlcs to Payer -- but I was wondering if you have any separate thoughts there.

Expose pending payment set from ChannelManager #1157

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

Expose pending payment set from `ChannelManager` #1157