Conversation
TheBlueMatt
left a comment
There was a problem hiding this comment.
Thanks for writing this up, good to have a spec for this.
blips/blip-0002.mediawiki
Outdated
| Receiver: | ||
| * if completing the payment, MUST fulfill the HTLC using the TLV-provided | ||
| payment preimage | ||
| * if failing the payment, SHOULD error with `PERM|15 |
There was a problem hiding this comment.
Should specify reason -> value, not just "if you fail for any reason, use this code".
blips/blip-0002.mediawiki
Outdated
| * SHOULD only send payments to nodes advertising feature bit 55 in the node | ||
| context starting June 1, 2022 | ||
|
|
||
| Receiver: |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
blips/blip-0002.mediawiki
Outdated
| * if failing the payment, SHOULD error with `PERM|15 | ||
| incorrect_or_unknown_payment_details`. | ||
| * MUST advertise feature bit 55 in the node context only starting June 1, 2022 | ||
|
|
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
There was a problem hiding this comment.
You mean TLV type 5482373484? Maybe in this section?
0f086a9 to
2ce13ef
Compare
t-bast
left a comment
There was a problem hiding this comment.
Thanks, it will be useful to have this in a shared document 👍
| ## bLIP Reserved Feature Bits | ||
| | Bits | Name | Description | Context | Dependencies | Link | | ||
| |-------|----------------------------------|-----------------------------------------------------------|----------|-------------------|---------------------------------------| | ||
| | 55 | `keysend` | Node supports receiving keysend payments | N | | [bLIP #0002][blip-0002] | |
There was a problem hiding this comment.
Are people relying on this specific value? It's a bit of a waste that it used a value so low, especially for a feature that will be obsolete once replaced by AMP...it would be nice if bLIPs used higher values for feature to avoid mixing official bolt features and bLIP features (but maybe that's just my OCD speaking)
There was a problem hiding this comment.
The tradeoff with higher feature bits, is that since we don't do any sparse encoding, higher feature bits (say in the tens of thousands) require the entire network to send around more data (looots of zeros onthe wire).
…re Bit/Message Type/TLV to Rationale, added Status diagram.
…re Bit/Message Type/TLV to Rationale, added Status diagram.
blips/blip-0002.mediawiki
Outdated
| * MUST include a TLV record keyed by type `5482373484` with a TLV value of a | ||
| randomly generated and cryptographically-secure 32-byte value that serves as | ||
| the HTLC payment preimage | ||
| * MUST NOT set a `payment_data` field |
There was a problem hiding this comment.
What's payment_data here?
4ea1653 to
3765e97
Compare
|
Should be moved to https://github.com/lightning/blips |
Thanks, moving! |
Currently rebased on #884
The portions regarding the keysend feature bit and MPP probably need more iteration, but wanted to get a draft out.