BOLT #7: Correct indentation typo in channel_update message#649
Merged
t-bast merged 2 commits intolightning:masterfrom Jul 23, 2019
Merged
BOLT #7: Correct indentation typo in channel_update message#649t-bast merged 2 commits intolightning:masterfrom
t-bast merged 2 commits intolightning:masterfrom
Conversation
Related to pull lightning#621 Corrected the indentation in the otherwise section in the `timestamp` check of the `channel_update` message. Both the if appeared at the same level of otherwise.
Collaborator
|
This indentation seems wrong, see https://github.com/lightningnetwork/lightning-rfc/blob/master/.copy-edit-stylesheet-checklist.md Indentations are supposed to be 2 spaces. |
Contributor
Author
|
@rustyrussell Thanks for pointing that out. I was oblivious of the accepted formatting for lightning docs. I have made the changes. |
t-bast
approved these changes
Jul 19, 2019
rustyrussell
approved these changes
Jul 22, 2019
Collaborator
rustyrussell
left a comment
There was a problem hiding this comment.
Ack 92df5d7
Please squash these together before commiting to master!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to pull #621
Corrected the indentation in the otherwise section in the
timestampcheck of thechannel_updatemessage. Both the actions that needed to be taken appeared at the same level which had to be indented.