Skip to content

Rephrase last node payload requirements#615

Merged
t-bast merged 1 commit intolightning:masterfrom
OrfeasLitos:final-onion
Jul 22, 2019
Merged

Rephrase last node payload requirements#615
t-bast merged 1 commit intolightning:masterfrom
OrfeasLitos:final-onion

Conversation

@OrfeasLitos
Copy link
Contributor

Mention that outgoing_cltv_value has to be equal to min_final_cltv_expiry and amt_to_forward has to be equal to amount, as seen in the invoice

t-bast
t-bast previously approved these changes May 27, 2019
Copy link
Collaborator

@t-bast t-bast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually thinking about this more, I prefer the previous "vague" wording.
You don't necessarily need to use a Bolt 11 invoice to pay someone / receive a payment.
The current wording is generally correct and less likely to change when new payment techniques are added.

@t-bast t-bast dismissed their stale review July 8, 2019 12:06

Dismissing my review as after some thoughts, I prefer the original sentence.

@OrfeasLitos
Copy link
Contributor Author

OrfeasLitos commented Jul 8, 2019

The old wording however leaves it unclear where these numbers come from. It definitely took me a while to understand what it meant, but a spec should try to help the reader. What do you think about something like this:

  • outgoing_cltv_value: set to the final expiry specified by the recipient (e.g. min_final_cltv_expiry in invoice)
  • amt_to_forward: set to the final amount specified by the recipient (e.g. amount in invoice)

or any other version that mentions min_final_cltv_expiry and amount from the invoice, but also allows for other ways of defining outgoing_cltv_value and amt_to_forward?

@t-bast
Copy link
Collaborator

t-bast commented Jul 8, 2019

That sounds good!
I would replace in invoice by from a [BOLT #11](11-payment-encoding.md) payment invoice but that's nit.

@OrfeasLitos
Copy link
Contributor Author

Great, I'll change it now

Mention that `outgoing_cltv_value` has to be equal to
`min_final_cltv_expiry` and `amt_to_forward` has to be equal to
`amount` if the [BOLT lightning#11](11-payment-encoding.md) invoice is used
@t-bast
Copy link
Collaborator

t-bast commented Jul 9, 2019

@cdecker could we get your opinion/ack on that small change?

Copy link
Collaborator

@t-bast t-bast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK ae0146f

@t-bast t-bast added the spelling These changes may be merged without additional sign off from the weekly meeting label Jul 9, 2019
@cdecker
Copy link
Collaborator

cdecker commented Jul 22, 2019

ACK ae0146f

@t-bast t-bast merged commit 238c062 into lightning:master Jul 22, 2019
@OrfeasLitos OrfeasLitos deleted the final-onion branch September 24, 2019 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

spelling These changes may be merged without additional sign off from the weekly meeting

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants