Specify tlv format, initial MPP#572
Closed
rustyrussell wants to merge 4 commits intolightning:masterfrom
Closed
Conversation
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This doesn't specify *how* they are encoded in the onion, since that's still being discussed. Currently it just defines switch_chain and switch_ephkey, which are simple. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
I don't use the odd-is-OK rule, because we have many other ways to break the format if we really want it. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Note the warning on non-amount MPP: unlike real goods with a receipt, the recipient is not necessarily motivated to wait for the entire payment (esp. if it's about to time out). Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
e5b2f45 to
490a5b7
Compare
Collaborator
Author
|
Too ambitious, stepping back for a moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.