Skip to content

channel-id and min_conf #6

@pm47

Description

@pm47
    type: 36 (MSG_FUNDING_LOCKED)
    data:
        [8:temporary-channel-id]
        [8:channel-id]
        [32:next-key-offset]
        [33:next-revocation-halfkey]

I have two questions about the channel-id field:

  1. A min_conf value of 0 or 1 could lead to each party computing a different channel-id. Easiest way is probably to just enforce a minimum value for min_conf? Yes a MIN_MIN_CONF!
  2. If we choose a MIN_MIN_CONF high enough so that the probability of computing a different channel-id is extremely low, why do we even need to specify the channel-id in this message? If we prefer to keep it here, then we need to specify what happens when they are not the same (probably just close the connection). I'd rather remove it, since we still need to handle the general case where we receive messages with unknown channel ids (e.g. in htlc messages).

Cheers,

Pierre

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions