-
Notifications
You must be signed in to change notification settings - Fork 525
Closed
Description
type: 36 (MSG_FUNDING_LOCKED)
data:
[8:temporary-channel-id]
[8:channel-id]
[32:next-key-offset]
[33:next-revocation-halfkey]
I have two questions about the channel-id field:
- A
min_confvalue of 0 or 1 could lead to each party computing a differentchannel-id. Easiest way is probably to just enforce a minimum value for min_conf? Yes aMIN_MIN_CONF! - If we choose a
MIN_MIN_CONFhigh enough so that the probability of computing a differentchannel-idis extremely low, why do we even need to specify thechannel-idin this message? If we prefer to keep it here, then we need to specify what happens when they are not the same (probably just close the connection). I'd rather remove it, since we still need to handle the general case where we receive messages with unknown channel ids (e.g. in htlc messages).
Cheers,
Pierre
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels