fix: Incorrect abs of hashes in BadMap#817
Merged
johanandren merged 1 commit intolightbend:mainfrom Jun 9, 2025
Merged
Conversation
Can lead to negative array indexes and throw out of bounds exception.
30a7f78 to
82ce561
Compare
Collaborator
Author
|
Reported over in one of the Pekko issue trackers: apache/pekko#1886 |
Collaborator
Author
|
Actually reported in this repo tracker as well, I had just missed it: #816 |
leviramsey
approved these changes
Jun 9, 2025
|
Seems like another case of premature optimization leading to broken behavior. At this point, why not remove |
leviramsey
reviewed
Jun 9, 2025
Collaborator
Author
|
@A248 thanks for the input, we'll limit any fallout by only doing this minimal fix and not introduce a larger change, even if that could be something worth considering. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Can lead to negative array indexes and throw out of bounds exception on config load