use correct ParseOptions object#709
Merged
havocp merged 1 commit intolightbend:masterfrom Sep 24, 2020
Merged
Conversation
havocp
approved these changes
Sep 24, 2020
Contributor
havocp
left a comment
There was a problem hiding this comment.
Thanks, sorry I missed that in round 1. I think cleaning up trailing whitespace is good, not sure where it came from either, but let's go for it.
Contributor
Author
|
Np, my bad for not following the other uses. Do we need to make sure this PR is mentioned in #702 for the release? |
Contributor
|
I added a comment over there but yeah it should be in NEWS.md ideally |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#708 has an issue with calling
ensureClassLoaderbut not using the result, this PR fixes that.Note: I'm not sure where the formatting fixes came from, could that be from
sbt test? I ran that locally. I can get rid of them if needed.