Merged
Conversation
Contributor
marcospereira
left a comment
There was a problem hiding this comment.
Some minor suggestion to use the latest versions.
Co-Authored-By: raboof <github@bzzt.net>
Co-Authored-By: raboof <github@bzzt.net>
Co-Authored-By: raboof <github@bzzt.net>
Co-Authored-By: raboof <github@bzzt.net>
Co-Authored-By: raboof <github@bzzt.net>
marcospereira
approved these changes
May 7, 2019
Contributor
marcospereira
left a comment
There was a problem hiding this comment.
@raboof, got tricked by Github UI saying there was a missing space in my suggestion, then it messed with the YAML formatting. Anyway, since it was a small change I've made it myself to avoid disturbing you again.
This LGTM.
ennru
reviewed
May 13, 2019
| - java -version | ||
| - curl -sL https://git.io/jabba | bash && . ~/.jabba/jabba.sh | ||
| - jabba install adopt@1.8.212-03 | ||
| - jabba install adopt@1.11.0-3 |
Member
There was a problem hiding this comment.
You could possibly use the ~ notation to use the latest build of the JDK versions.
Contributor
There was a problem hiding this comment.
Not working right now for adopt@~1.11. I assume jabba is failing to correct check versions such as adopt@1.11.0-2 because of the -2 section. Anyway, should not block this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.