Add StringFormatLoggingToParameterized and MessageFormatLoggingToParameterized recipes to transform logging to SLF4J parameterized format. Add RemoveUnnecessaryLogLevelGuards recipe to remove redundant if-statement guards around SLF4J logging calls.#3336
Merged
Conversation
Jacoco Code Coverage
Files
|
70f727c to
cf3aaff
Compare
Collaborator
Author
|
@timtebeek I wanted to show you these OpenRewrite recipes that I'm going to land in Liftwizard. Once I'm confident they work well, I could contribute them to openrewrite/rewrite-logging-frameworks. RemoveUnnecessaryLogLevelGuards mostly addresses openrewrite/rewrite-logging-frameworks#127. |
|
Thanks for sharing! Yes seems like they'd fit right in. Especially like the simplification achieved with |
e743c50 to
185fb67
Compare
…meterized recipes to transform logging to SLF4J parameterized format. Add RemoveUnnecessaryLogLevelGuards recipe to remove redundant if-statement guards around SLF4J logging calls.
185fb67 to
1c12105
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.