Skip to content

Pip: Fallback Homepage to Project-URLs#948

Merged
MikeMcQuaid merged 5 commits into
licensee:mainfrom
julia-thorn:use-pip-defaults-homepage
Mar 18, 2026
Merged

Pip: Fallback Homepage to Project-URLs#948
MikeMcQuaid merged 5 commits into
licensee:mainfrom
julia-thorn:use-pip-defaults-homepage

Conversation

@julia-thorn

Copy link
Copy Markdown
Contributor

Summary

In PEP-753 Home-Page was deprecated in favor of Project-URLs. This allows licensed to use the Project-URLs when Home-Page is missing.

Changes

  • Parse pip show --verbose output so multi-line/indented metadata fields are preserved.
  • Keep existing behavior of preferring Home-page when present.
  • Add fallback to Project-URL / Project-URLs when Home-page is empty.
  • Apply URL selection priority: Home > Repository > Source > first valid URL.
  • Add tests covering continuation-line parsing and multi-URL priority behavior.

@julia-thorn julia-thorn marked this pull request as draft March 17, 2026 16:13

@MikeMcQuaid MikeMcQuaid left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments otherwise: looks good when 🟢!

Comment thread test/sources/pip_test.rb Outdated
Comment thread lib/licensed/sources/pip.rb Outdated
@julia-thorn julia-thorn marked this pull request as ready for review March 17, 2026 17:33
@julia-thorn julia-thorn requested a review from MikeMcQuaid March 17, 2026 17:33

@MikeMcQuaid MikeMcQuaid left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @julia-thorn!

@MikeMcQuaid MikeMcQuaid merged commit 3a50007 into licensee:main Mar 18, 2026
43 checks passed
@julia-thorn

Copy link
Copy Markdown
Contributor Author

Hi @MikeMcQuaid — this is a pretty small change, so no need to release now, but I wanted to check when you think it might be released (or if there’s a regular release schedule). Thanks!

@MikeMcQuaid

Copy link
Copy Markdown
Contributor

@julia-thorn Hi! No specific release schedule/cycle planned, normally just when there's something important enough.

@julia-thorn

Copy link
Copy Markdown
Contributor Author

@MikeMcQuaid Makes sense, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants