Fix for pip packages#856
Merged
Merged
Conversation
Handle packages with the separator pattern in their info
|
@MikeMcQuaid - could you bump the gem's version so we can have this fix available? |
Contributor
|
@taltcher Yes, I'm doing so now. I merged this 15 minutes ago. A little patience please 😀 |
|
@MikeMcQuaid of course 😄 thanks a lot for the quick handling! |
Contributor
|
@taltcher @nadavshatz Released now in v5.0.4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle packages with the separator pattern in their info
An example package for this is
json5.if you run
pip show json5 zippfor instance you'll see that the---is present in the licenses list which breaks thelicensed cacherun for projects that have these pip packages.This fix covers that separating the calls to
pip showand parallelizes them since in large projects this can also take >10m just to load since pip by default does them one by one.