Skip to content

Add csv as a dependency for Ruby 3.4+#786

Merged
MikeMcQuaid merged 4 commits into
licensee:mainfrom
gjtorikian:main
Feb 6, 2025
Merged

Add csv as a dependency for Ruby 3.4+#786
MikeMcQuaid merged 4 commits into
licensee:mainfrom
gjtorikian:main

Conversation

@gjtorikian

@gjtorikian gjtorikian commented Jan 8, 2025

Copy link
Copy Markdown
Contributor

Fixes #752.

As the issue says, the gem can't be used with Ruby 3.4, because csv was taken out of the Ruby standard library. csv is being used by the Gradle source.

@gjtorikian

Copy link
Copy Markdown
Contributor Author

@dangoor Any chance this can be merged and released?

@dangoor

dangoor commented Jan 27, 2025

Copy link
Copy Markdown
Contributor

@gjtorikian Thanks for your patience here. We're working on improving the maintenance of this project in the very near term.

I'll try to get your change merged in and released in the meantime, but I am very short on time right now so I can't guarantee it.

@dangoor

dangoor commented Jan 28, 2025

Copy link
Copy Markdown
Contributor

@gjtorikian Sorry, I'm running out of time on this. Can you run licensed cache to add the metadata for csv?

@gjtorikian

Copy link
Copy Markdown
Contributor Author

Sure thing, done.

@dangoor

dangoor commented Jan 29, 2025

Copy link
Copy Markdown
Contributor

@gjtorikian I don't know why licensed called the license other for csv, because it is clearly BSD-2-Clause. Because it showed up as other, we need to add it to the reviewed section of licensed.yml. Can you make that change?

@gjtorikian

Copy link
Copy Markdown
Contributor Author

done, and rebased !

@dangoor

dangoor commented Jan 29, 2025

Copy link
Copy Markdown
Contributor

@gjtorikian Sorry to say it, but I'm wary of merging the CI failure. It looks completely unrelated... Unfortunately, I didn't get a chance to finish this up (or finish moving this into its new community-driven org) before I'm going to be unavailable for a few days. I'll look to get this picked back up next week (unless someone else happens to get to it before me).

licensed should be in a better place for community contribution soon!

Comment thread .licenses/bundler/csv.dep.yml Outdated

@MikeMcQuaid MikeMcQuaid left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gjtorikian!

@MikeMcQuaid

Copy link
Copy Markdown
Contributor

Merging as this is a known problem and none of these failing CI jobs bear any resemblance to what's been actually changed (Ruby) and the majority are passing.

@MikeMcQuaid MikeMcQuaid merged commit 951a7ef into licensee:main Feb 6, 2025
@gjtorikian

Copy link
Copy Markdown
Contributor Author

Thanks Mike. Any chance for a new release cut?

@MikeMcQuaid

Copy link
Copy Markdown
Contributor

@gjtorikian I'm planning it in the next few hours!

@MikeMcQuaid

Copy link
Copy Markdown
Contributor

@gjtorikian v5.0.2 was just released with this PR.

@gjtorikian

Copy link
Copy Markdown
Contributor Author

thank you~!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

CSV inclusion warning for Ruby 3.4.0

4 participants