Conversation
santigimeno
approved these changes
Dec 16, 2024
Member
santigimeno
left a comment
There was a problem hiding this comment.
I missed this. Thanks for taking care of it
Member
Author
|
👍 the function is quite involved, it's easy to miss! I also had to look twice 😅 |
|
Sorry for bothering you. Could we release a version with this fix? This issue results in severe memory leaks for Nuxt users on Windows nuxt/devtools#761 nuxt/cli#628. Since It might take more than a month until node picks the upgrade of libuv, it would be nice if a patch for libuv is released before the next node release. |
Member
Author
|
Node does apply fixes to the vendored libuv they have. If this is Bad (TM) I'd suggest you open an issue in Node and ask for a cherry-pick. That said, a release is due IMHO! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #4376 (comment)