Skip to content

win: drop support for windows 8#4624

Merged
bnoordhuis merged 1 commit intolibuv:v1.xfrom
bnoordhuis:drop-win8
Nov 28, 2024
Merged

win: drop support for windows 8#4624
bnoordhuis merged 1 commit intolibuv:v1.xfrom
bnoordhuis:drop-win8

Conversation

@bnoordhuis
Copy link
Copy Markdown
Member

@bnoordhuis bnoordhuis commented Nov 27, 2024

Fixes: #3889

There's probably more that can be simplified now. Suggestions?

@bnoordhuis
Copy link
Copy Markdown
Member Author

bnoordhuis commented Nov 27, 2024

I don't get why GetFileInformationByName is undefined... is that not a thing on Windows Server 2019/2022?

@vtjnash
Copy link
Copy Markdown
Member

vtjnash commented Nov 27, 2024

GetFileInformationByName was added last year

@bnoordhuis
Copy link
Copy Markdown
Member Author

bnoordhuis commented Nov 27, 2024

Okay, so not safe to assume it's there, even on win10?

@vtjnash
Copy link
Copy Markdown
Member

vtjnash commented Nov 27, 2024

Right, officially it isn't even part of Windows 11 yet (https://learn.microsoft.com/en-us/windows/win32/api/winbase/nf-winbase-getfileinformationbyname)

@huseyinacacak-janea
Copy link
Copy Markdown
Contributor

huseyinacacak-janea commented Nov 27, 2024

The GetFileInformationByName function was introduced to libuv as part of this PR. If I am not wrong, this API became available starting with Windows 11, version 24H2. Therefore, it’s not safe to assume that it will be present on all Windows 10 systems. Additionally, this API is available in Windows Server 2025 but not sure in Server 2019 and 2022.

@bnoordhuis
Copy link
Copy Markdown
Member Author

bnoordhuis commented Nov 28, 2024

Okay, I dropped that change. Anything else that can be cut?

saghul
saghul approved these changes Nov 28, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@saghul saghul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At a quick glance I don't see anything else.

@bnoordhuis bnoordhuis merged commit 1464408 into libuv:v1.x Nov 28, 2024
@bnoordhuis bnoordhuis deleted the drop-win8 branch November 28, 2024 21:02
@bnoordhuis bnoordhuis mentioned this pull request Feb 16, 2025
Open
@Streamlet
Copy link
Copy Markdown

Streamlet commented Dec 5, 2025

Why drop support Win8?
Is there an API that provided by Win10 and MUST be used?

@saghul
Copy link
Copy Markdown
Member

saghul commented Dec 5, 2025

Read here: #3889

@Streamlet

This comment was marked as off-topic.

Sign in to view
@libuv libuv locked as resolved and limited conversation to collaborators Dec 6, 2025
@libuv libuv deleted a comment from Streamlet Dec 6, 2025
@bnoordhuis
Copy link
Copy Markdown
Member Author

bnoordhuis commented Dec 6, 2025

Locked, deleted an off-topic comment, and hid the other. Save diatribes for your personal blog.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@saghul saghul saghul approved these changes

Assignees

No one assigned

Labels

windows

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Drop Windows 8.1 compatibility, on Jan 1, 2024

5 participants

@bnoordhuis @vtjnash @huseyinacacak-janea @Streamlet @saghul