Fix linked list logic in windows getaddrinfo#4578
Merged
vtjnash merged 1 commit intolibuv:v1.xfrom Oct 17, 2024
Merged
Conversation
vtjnash
approved these changes
Oct 11, 2024
Contributor
|
@vtjnash Sorry to be "that guy" again, but this commit seems to have broken Neovim tests: https://github.com/neovim/neovim/actions/runs/11416186835/job/31767451321?pr=30861#step:7:9106 To reproduce (on Windows):
|
Contributor
|
Ah, sorry, the changelog lied to me -- it might be one of the other, unlisted, EDIT: No, bisected the test failure to this commit. |
Contributor
|
Sorry, turns out that this was just very stubborn flake on this test that happened to pass only on that one commit. Sorry for the noise! |
Member
|
No problem, better too much noise than too little. We always want to hear about potential regressions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logic in #4254 is incorrect, and results in the addrinfo linked list only having a single result. Fix this by correcting the logic.
Closes #4577