win,pipe: fix another missing assignment to success#4523
Merged
vtjnash merged 1 commit intolibuv:v1.xfrom Sep 5, 2024
Merged
Conversation
saghul
approved these changes
Aug 31, 2024
Contributor
|
Happy to report that on this PR, the Windows workflow passes consistently (re-ran it three times to make sure)! |
Contributor
|
Sanitizer fail looks like a flake -- can anybody rerun the check? |
Member
Author
|
It is an unexpected flake, but not on a platform that was changed here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yet another followup to #4511.
functional/legacy/increment_spec.luafailed most of the time without this. You would think I had never written software before or something. Hopefully this is the last fix to this PR🤞