win,pipe: fix missing assignment to success#4515
Merged
vtjnash merged 1 commit intolibuv:v1.xfrom Aug 28, 2024
Merged
Conversation
cjihrig
approved these changes
Aug 22, 2024
santigimeno
approved these changes
Aug 22, 2024
Closed
Contributor
|
Happy to report that this made Neovim's CI pass 🥳 |
Contributor
|
...but only sporadically. Looks like there are still some (race?) conditions that make Neovim crash, see https://github.com/neovim/neovim/actions/runs/10613559661/job/29419056735?pr=29915 (e.g., |
Contributor
|
The crashes (at least some of them) are locally reproducible and are related to writing a lot of data to a pipe. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise this accidentally results in
r == 1(aka UV_EISDIR) on this code path, which can be quite confusing for the caller indeed. I now ran all of the neovim tests locally this time, and none hang (some fail, but seems like that is because it expects some test dependencies to be installed, and I don't know what they are)