linux: disable SQPOLL io_uring by default#4492
Merged
santigimeno merged 1 commit intolibuv:v1.xfrom Aug 6, 2024
Merged
Conversation
saghul
approved these changes
Aug 6, 2024
vtjnash
approved these changes
Aug 6, 2024
bnoordhuis
approved these changes
Aug 6, 2024
The SQPOLL io_uring instance wasn't providing consistent behaviour to users depending on kernel versions, load shape, ... creating issues difficult to track and fix. Don't use this ring by default but allow enabling it by calling `uv_loop_configure()` with `UV_LOOP_ENABLE_IO_URING_SQPOLL`.
4447f50 to
4119567
Compare
Member
Author
|
BTW, in hindsight, Colin's idea, at least for io_uring, wasn't that far fetched. |
|
@santigimeno Is this a problem even on recent Linux kernels? |
Member
Author
I haven't tested, but I don't think it matters. For a general purpose library using |
|
How does the embedder (e.g. Node) know whether or not to enable this? |
Member
|
You probably don't. Best to leave that up to the user/administrator, through a flag. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SQPOLL io_uring instance wasn't providing consistent behaviour to users depending on kernel versions, load shape, ... creating issues difficult to track and fix. Don't use this ring by default but allow enabling it by calling
uv_loop_configure()withUV_LOOP_ENABLE_IO_URING_SQPOLL.Refs: #4421 (comment)