test: fix the flaky test-tcp-reuseport#4417
Merged
saghul merged 2 commits intolibuv:v1.xfrom May 30, 2024
Merged
Conversation
Start connecting to the peers after all threads to poll for accepting connections. For libuv#4407 --------- Signed-off-by: Andy Pan <i@andypan.me>
Contributor
Author
|
/cc @saghul @santigimeno |
Contributor
Author
|
It seemed that connecting to the listeners that have not yet started polling for accepting may not get the incoming connections to be distributed across all listening threads. Check out https://github.com/libuv/libuv/actions/runs/9190479225/job/25274784544 |
--------- Signed-off-by: Andy Pan <i@andypan.me>
saghul
approved these changes
May 23, 2024
Contributor
Author
|
Hi @santigimeno, got a minute for this? |
saghul
approved these changes
May 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Start connecting to the peers after all threads
to poll for accepting connections.
For #4407