unix: reinstate preadv fallback code#4345
Merged
bnoordhuis merged 1 commit intolibuv:v1.xfrom Mar 20, 2024
Merged
Conversation
86a6b37 to
4c8312f
Compare
Member
|
I think we need to dynamically check for |
vtjnash
reviewed
Mar 7, 2024
I removed the fallback code back in October but it prevents Node.js from upgrading libuv in their v20.x release line because they support systems older than we do. Bring back a dlsym-based fallback path. Fixes: libuv#4332
Member
Author
Done. |
Member
Author
|
@santigimeno wanted to double-check, this LGTY? |
santigimeno
approved these changes
Mar 20, 2024
Member
santigimeno
left a comment
There was a problem hiding this comment.
LGTM, I just launched https://ci.nodejs.org/view/libuv/job/libuv-test-commit/2286/ just to be sure it doesn't break anything in the other platforms not supported via GH actions,
Member
Author
|
The recurring test failure is a cgroups v1 thing I fixed in 91ba130 recently. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I removed the fallback code back in October but it prevents Node.js from upgrading libuv in their v20.x release line because they support systems older than we do. Bring back a dlsym-based fallback path.
Fixes: #4332