Skip to content

linux: disable io_uring on ppc64 and ppc64le#4285

Merged
santigimeno merged 1 commit intolibuv:v1.xfrom
bradking:linux-ppc64le-no-io_uring
Jan 13, 2024
Merged

linux: disable io_uring on ppc64 and ppc64le#4285
santigimeno merged 1 commit intolibuv:v1.xfrom
bradking:linux-ppc64le-no-io_uring

Conversation

@bradking
Copy link
Copy Markdown
Contributor

Since io_uring support was added, libuv's signal handler randomly segfaults on
ppc64le when interrupting epoll_pwait. Disable it pending further investigation.

Issue: #4283

Copy link
Copy Markdown
Member

@santigimeno santigimeno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this change. One question: by @glaubitz comments in #4283 I was implying the failures also happened in ppc64 as the cfarm203 box has that architecture. Is this correct or only happened in ppc64le?

@glaubitz
Copy link
Copy Markdown

I'm fine with this change. One question: by @glaubitz comments in #4283 I was implying the failures also happened in ppc64 as the cfarm203 box has that architecture. Is this correct or only happened in ppc64le?

It affects both ppc64le and ppc64 (both little-endian and big-endian).

@bradking bradking changed the title linux: disable io_uring on ppc64le linux: disable io_uring on ppc64 and ppc64le Jan 12, 2024
@bradking bradking force-pushed the linux-ppc64le-no-io_uring branch from b67143d to 9ee167f Compare January 12, 2024 21:40
Since `io_uring` support was added, libuv's signal handler randomly
segfaults on ppc64 when interrupting `epoll_pwait`.  Disable it
pending further investigation.

Issue: libuv#4283
@bradking bradking force-pushed the linux-ppc64le-no-io_uring branch from 9ee167f to 08f4fb4 Compare January 12, 2024 21:42
@bradking
Copy link
Copy Markdown
Contributor Author

Thanks. I updated the PR to cover both ppc64 and ppc64le.

@santigimeno santigimeno merged commit 3b6a1a1 into libuv:v1.x Jan 13, 2024
@bradking bradking deleted the linux-ppc64le-no-io_uring branch January 13, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants