[RFC] export WTF8 conversion utilities#4021
Merged
vtjnash merged 6 commits intolibuv:v1.xfrom Oct 29, 2023
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Member
|
I'm fine with adding this, it seems useful. What's left to have this ready? I guess we should add some tests for the new methods? |
Member
Author
|
More tests are probably always good, but this is mostly about using the new code everywhere (covered by existing tests) and then making it exported also just because it requires no extra work to do so. |
Member
Author
|
Are you fine with this API? |
Member
|
I'm fine with this API. |
vtjnash
commented
Oct 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As promised in #2970, this attempts to migrate code to a common set of utilities in a common place in the code and use them everywhere. This also exports the functionality, since the Windows API with WideCharToMultiByte is fairly verbose relative to what libuv and libuv's clients typically need, so it is useful not to require clients to reimplement this conversion logic unnecessarily (and because Windows is not 64-bit ready here, but this implementation is.)