So after the new v1.49.0 release, the Node.js test suite is failing pretty badly specially with the child_process tests. See:
nodejs/node#55114. My bad I didn't catch this before the release, but was having problems with the CI on Windows.
I've been looking at the changes and it seems to come from the change in #4470.
So as an example, when running the following test, the process never exits:
out/Release/node.exe test/parallel/test-child-process-fork.js
Reverting all changes in win/pipe.c make the tests to pass again (at least most of them)
/cc @vtjnash
So after the new
v1.49.0release, the Node.js test suite is failing pretty badly specially with thechild_processtests. See:nodejs/node#55114. My bad I didn't catch this before the release, but was having problems with the CI on Windows.
I've been looking at the changes and it seems to come from the change in #4470.
So as an example, when running the following test, the process never exits:
Reverting all changes in
win/pipe.cmake the tests to pass again (at least most of them)/cc @vtjnash