This repository was archived by the owner on Feb 12, 2025. It is now read-only.
[SECURITY] Verify LZW code fits in 12 bits before we use it#8
Merged
ctrlcctrlv merged 1 commit intomasterfrom Jun 9, 2021
Merged
[SECURITY] Verify LZW code fits in 12 bits before we use it#8ctrlcctrlv merged 1 commit intomasterfrom
ctrlcctrlv merged 1 commit intomasterfrom
Conversation
The type `unsigned short`, which is the type of the LZW code, is much larger than the max of an LZW code, causing a wild pointer. That causes an array overflow. Long term, this library should jettison this unnecessary GIF code, and use a better maintained library for it. In the meantime, however, the issue is simple enough to solve, so I've done so. Resolves CVE-2020-19668. Closes saitoha#136. Closes #7.
This was referenced Jun 9, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The type
unsigned short, which is the type of the LZW code, is muchlarger than the max of an LZW code, causing a wild pointer.
That causes an array overflow. Long term, this library should jettison
this unnecessary GIF code, and use a better maintained library for it.
In the meantime, however, the issue is simple enough to solve, so I've
done so.
Resolves CVE-2020-19668.
Closes saitoha#136.
Closes #7.