This repository was archived by the owner on Feb 12, 2025. It is now read-only.
Add sixel_decode_raw_rgba, fix decoding of high-color SIXEL's#23
Open
ctrlcctrlv wants to merge 1 commit intomasterfrom
Open
Add sixel_decode_raw_rgba, fix decoding of high-color SIXEL's#23ctrlcctrlv wants to merge 1 commit intomasterfrom
ctrlcctrlv wants to merge 1 commit intomasterfrom
Conversation
Closes #15. Closes #16. Closes saitoha#149. Closes saitoha#28. Closes saitoha#61. This PR fixes both problems at once. It does so by adding a new decode function, and using it by default in `img2sixel`. This function returns to the user RGBA data instead of palette'd data. This sidesteps the many issues I found when considering raising the maximum size of a palette to 255*255*255*255. For one thing, I already knew I needed at some point for Kitty project something like this so I wouldn't need to allocate my own, which is needless effort when the decoder can do it. This is ready for review. @dankamongmen may have time. I'll leave it for a while as I go back to working on Kitty. If no one has time to review, I'll merge it in ~4 days or so.
This was referenced Jun 16, 2021
Collaborator
Author
|
Let's hold off on reviewing and merging this. I need to support encoding as well, although I was considering #24 a separate issue. On the plus side, decoding does work. Here's some proof (I've intentionally used fuchsia as my background to prove that it works):
You can see that the transparent pixels are showing through in this simple Sixel file, where before they'd be black (or sometimes another random color due to weird behavior of |
|
Can you update tests to resolve conflict and get the CI to run again? I'd love to see this merged in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15.
Closes #16.
Closes saitoha#149.
Closes saitoha#28.
Closes saitoha#61.
This PR fixes both problems at once. It does so by adding a new decode
function, and using it by default in
img2sixel.This function returns to the user RGBA data instead of palette'd data.
This sidesteps the many issues I found when considering raising the
maximum size of a palette to 255*255*255*255. For one thing, I already
knew I needed at some point for Kitty project something like this so I
wouldn't need to allocate my own, which is needless effort when the
decoder can do it.
This is ready for review. @dankamongmen may have time. I'll leave it for
a while as I go back to working on Kitty. If no one has time to review,
I'll merge it in ~4 days or so.